Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line props #422

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

d-fischer
Copy link

This PR is a two-for-one: it fixes two issues that keep me (and apparently others, as I found the issues to already exist) from working with lineProps in this library productively.

  • It now passes lineNumber properly even if showLineNumbers is false
  • It now merges the className property with the classes added internally instead of overwriting them

Fixes #288
Fixes #391

@d-fischer
Copy link
Author

I updated the wrap-lines snapshot file. Now it looks like this fails the exact same tests as master, and I won't update these as the "new" results clearly seem broken (and, as I said, not by me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant