Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade chart.js 2.7.2 and fix #247 #327

Conversation

mizukami234
Copy link

@mizukami234
Copy link
Author

Hi @jerairrest , could you please merge this?
I need this bugfix: chartjs/Chart.js#4937

@bagratinho
Copy link

please @jerairrest take time to merge this as I assume this will also fix #337

@rpearce
Copy link

rpearce commented Mar 29, 2019

If chart.js is a peerDependency, as shown here https://github.com/jerairrest/react-chartjs-2/blob/master/package.json#L67, then you should be able to specify your own chart.js version in your project, and that will take precedence.

I am not in charge of this project but just came across this PR.

@jerairrest
Copy link
Collaborator

I agree with rpeace. Closing since a peer dependency would fix this issue.

@jerairrest jerairrest closed this Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mix chart, labels.slice is not a function error
4 participants