Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TS): Error impls now properly type this #4978

Merged
merged 1 commit into from Aug 26, 2019
Merged

fix(TS): Error impls now properly type this #4978

merged 1 commit into from Aug 26, 2019

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Aug 22, 2019

Fixes an issue with TypeScript compilation in more strict environments.

@benlesh
fix(TS): Error impls now properly type this
f4239e4 
Fixes an issue with TypeScript compilation in more strict environments.
@benlesh benlesh requested a review from cartant August 22, 2019 15:24
@benlesh benlesh mentioned this pull request Aug 22, 2019
Closed
cartant
cartant approved these changes Aug 24, 2019
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit 7606dc7 into ReactiveX:master Aug 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwonoj kwonoj kwonoj approved these changes

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benlesh @kwonoj @cartant