This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
[added] Add renderMenuWrapper prop
#349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it possible to render the menu in a portal while keeping `refs.menu` on the actual menu element, so that scrolling items into view keeps working. Test plan: Added unit test; verified that this works with a portal in an actual production application.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it possible to render the menu in a portal while keeping
refs.menuon the actual menu element, so that scrolling items intoview keeps working.
Test plan: Added unit test; verified that this works with a portal in an
actual production application.