Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed fix for #29 #39

Merged
merged 3 commits into from May 2, 2017
Merged

Proposed fix for #29 #39

merged 3 commits into from May 2, 2017

Commits on Apr 19, 2017

  1. Proposed fix for reactjs#29 

    This was hijacking the child ref onto the `CSSTransitionGroupChild`, this fix for reactjs#29 leaves the ref on child and lets the `TransitionGroup` add a ref to the wrapped child produced from `childFactory()`.  (assumption: `childFactory()` always wraps the child) An improvement would to detect if the child was wrapped or not and chain appropriately.
    @aligon
    aligon committed Apr 19, 2017
    Copy the full SHA
    d2e9889 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2017

  1. Only chain the refs if the factory produces a different element than … 

    …the child
    Andrew Ligon committed Apr 26, 2017
    Copy the full SHA
    be09dc5 View commit details
    Browse the repository at this point in the history

  2. Test that the refs get set up correctly

    Andrew Ligon committed Apr 26, 2017
    Copy the full SHA
    d8a0c00 View commit details
    Browse the repository at this point in the history