Updated to use refs rather than findNode
#486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… crashing in my usage.
eps1lon
reviewed
Apr 11, 2019
| @@ -357,6 +361,8 @@ class Transition extends React.Component { | |||
| delete childProps.onExiting | |||
| delete childProps.onExited | |||
|
|
|||
| childProps.ref = this.setChildNode | |||
There was a problem hiding this comment.
This will override the ref that is attached to child.
There was a problem hiding this comment.
And what about user component? Example
class Button extends React.Component {}
ref returned Symbol but not Element
4 tasks
|
@inomdzhon @eps1lon what's keeping this MR from being merged? |
@bensampaio, this PR 559, no? |
|
🎉 This issue has been resolved in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a situation where
findNodewas throwing an error because the node wasn't mounted yet.