Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds missing dependency @babel/runtime #507

Merged
merged 2 commits into from Jun 10, 2019

Commits on Jun 4, 2019

  1. adds missing dependency @babel/runtime

    Using yarn with pnp enabled enforces a correct dependency structure. While using any module that has this package as a dependency I get the following error:
    
    ```
    ERROR in /home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/CSSTransition.js
    Module not found: Error: Package "react-transition-group@4.1.0" (via "/home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/CSSTransition.js") is trying to require the package "@babel/runtime" (via "@babel/runtime/helpers/esm/extends") without it being listed in its dependencies (react, react-dom, dom-helpers, loose-envify, prop-types, react-transition-group)
     @ /home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/CSSTransition.js 1:0-58 228:43-51
     @ /home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/index.js
     @ /home/msilva/.cache/yarn/v4/npm-@material-ui-core-4.0.2-c7a07c1d1b13b94adf479d7267b51cb682fcb279/node_modules/@material-ui/core/Slide/Slide.js
    ```
    
    to fix this I added the latest version of @babel/runtime to the dependencies.
    marco-silva0000 committed Jun 4, 2019
    Copy the full SHA
    f13e1f7 View commit details
    Browse the repository at this point in the history
  2. fix typo

    marco-silva0000 committed Jun 4, 2019
    Copy the full SHA
    85ea462 View commit details
    Browse the repository at this point in the history