Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning about deprecated findDOMNode usage #537

Closed
wants to merge 2 commits into from
Closed

Remove warning about deprecated findDOMNode usage #537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4cc10b
Remove warning about deprecated findDOMNode usage
iegik Aug 12, 2019
dab0829
Remove ReactDOM unnecessary dependency
iegik Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Transition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import PropTypes from 'prop-types'
import React from 'react'
import ReactDOM from 'react-dom'

import config from './config'
import { timeoutsShape } from './utils/PropTypes'
Expand Down Expand Up @@ -117,6 +116,7 @@ class Transition extends React.Component {
let initialStatus

this.appearStatus = null
this.ref = React.createRef();

if (props.in) {
if (appear) {
Expand Down Expand Up @@ -210,7 +210,7 @@ class Transition extends React.Component {
if (nextStatus !== null) {
// nextStatus will always be ENTERING or EXITING.
this.cancelNextCallback()
const node = ReactDOM.findDOMNode(this)
const node = this.ref;

if (nextStatus === ENTERING) {
this.performEnter(node, mounting)
Expand Down Expand Up @@ -362,7 +362,7 @@ class Transition extends React.Component {
const child = React.Children.only(children)
return (
// allows for nested Transitions
<TransitionGroupContext.Provider value={null}>
<TransitionGroupContext.Provider value={{ ref: this.ref }}>
{React.cloneElement(child, childProps)}
</TransitionGroupContext.Provider>
)
Expand Down