Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nodeRef alternative instead of internal findDOMNode #559

Merged
merged 7 commits into from May 5, 2020
Merged

feat: add nodeRef alternative instead of internal findDOMNode #559

merged 7 commits into from May 5, 2020

Commits on May 1, 2020

  1. feat: add nodeRef alternative instead of internal findDOMNode

    @iamandrewluca
    iamandrewluca committed May 1, 2020
    Copy the full SHA
    1f53b09 View commit details
    Browse the repository at this point in the history

  2. refactor: adapt stories to use nodeRef

    @iamandrewluca
    iamandrewluca committed May 1, 2020
    Copy the full SHA
    2e5619b View commit details
    Browse the repository at this point in the history

  3. test: check when findDOMNode is called w or w/o nodeRef

    @iamandrewluca
    iamandrewluca committed May 1, 2020
    Copy the full SHA
    af2160c View commit details
    Browse the repository at this point in the history

  4. docs: add two more stories how to use with innerRef and forwardRef

    @iamandrewluca
    iamandrewluca committed May 1, 2020
    Copy the full SHA
    a8d9e3c View commit details
    Browse the repository at this point in the history

  5. test: improve tests, stories, and move nodeRef propType upper

    @iamandrewluca
    iamandrewluca committed May 1, 2020
    Copy the full SHA
    a27ffa0 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. fix(ReplaceTransition): check child nodeRef instead of adding 2 props

    @iamandrewluca
    iamandrewluca committed May 5, 2020
    Copy the full SHA
    ff2fdfc View commit details
    Browse the repository at this point in the history

  2. Update documentation formatting for nodeRef

    @silvenon
    silvenon committed May 5, 2020
    Copy the full SHA
    5c1daf5 View commit details
    Browse the repository at this point in the history