Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename createRoot & createBlockingRoot to unstable_createRoot & unst… #2962

Closed
wants to merge 2 commits into from
Closed

Conversation

raghav0622
Copy link

@raghav0622 raghav0622 commented May 9, 2020

[concurrent mode docs] Rename createRoot & createBlockingRoot with unstable_createRoot & unstable_createBlockingRoot with refrence to latest changes in experimental apis in pr
facebook/react#18825

also closes #2960 (comment)

Issue Number: 2960

@facebook-github-bot
Copy link
Collaborator

Hi @raghav0622!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 requested a review from gaearon May 9, 2020 19:50
@gaearon
Copy link
Member

gaearon commented May 9, 2020

Hmm why didn't CI trigger a website build..

@gaearon
Copy link
Member

gaearon commented May 9, 2020

It's not just createRoot, there's also useTransition, etc. It gets pretty noisy if you add it everywhere in the docs.

I think what we should do instead is to add a new section in Adopting that explains each export is behind unstable_. And has a map of them.

@raghav0622
Copy link
Author

It's not just createRoot, there's also useTransition, etc. It gets pretty noisy if you add it everywhere in the docs.

I think what we should do instead is to add a new section in Adopting that explains each export is behind unstable_. And has a map of them.

but still the code examples would need unstable_ as it would be ambigious if unstable is omitted from code examples. i'll create a new pr with separate section explaining unstable

@facebook-github-bot facebook-github-bot deleted the branch reactjs:master July 6, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrent UI Patterns needs to be updated with unstable_ prefixes
3 participants