Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useTransition documentation to remove references to timeoutMS #4238

Closed
wants to merge 2 commits into from

Conversation

droidenator
Copy link

This PR deletes references to timeoutMS in the documentation about useTransition. For users starting to adopt React 18, it's very confusing that the official documentation still references a deleted config option. Here's the PR that disables timeoutMS: facebook/react#19703

Remove references to removed `timeoutMS` config option for `useTransition`
@facebook-github-bot
Copy link
Collaborator

Hi @droidenator!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions
Copy link

github-actions bot commented Jan 25, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@harish-sethuraman
Copy link
Collaborator

Caution:
This page was about experimental features that aren’t yet available in a stable release. It was aimed at early adopters and people who are curious.
Much of the information on this page is now outdated and exists only for archival purposes. Please refer to the React 18 Alpha announcement post for the up-to-date information.
Before React 18 is released, we will replace this page with stable documentation.

As document suggests the
Much of the information on this page is now outdated and exists only for archival purposes

@droidenator
Copy link
Author

@harish-sethuraman I see that but there's literally no other documentation, at least that I've found, on reactjs.org regarding useTransition. As a lot of folks ramp up on this new hook, they're going to be referencing these docs. Since the only real change is removing text about a config that was removed in August 2020, that seems like it's worth updating.

@harish-sethuraman
Copy link
Collaborator

There is a link to the react working group in this page -> https://reactjs.org/blog/2021/06/08/the-plan-for-react-18.html where you can find detailed discussions related to react 18 and its release

More about useTransition here -> reactwg/react-18#41

@droidenator droidenator deleted the patch-3 branch January 25, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants