Ignoring flaky JCStress tests

FluxSwitchMap and FluxSwitchOnFirst JCStress tests are failing randomly and it needs to be investigated why. We don't want their flakiness to hide other issues when the CI fails, so they are being investigated in related issues. Related #3633 Related #3627
reactor · Jan 10, 2024 · 081e2e1 · 081e2e1
1 parent 3a77755
commit 081e2e1
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 14 deletions.
diff --git a/reactor-core/src/jcstress/java/reactor/core/publisher/FluxSwitchMapStressTest.java b/reactor-core/src/jcstress/java/reactor/core/publisher/FluxSwitchMapStressTest.java
@@ -270,7 +270,8 @@ public void arbiter(II_Result r) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3633)
+	//@JCStressTest
 	@Outcome(id = {"200, 0", "200, 1"}, expect = ACCEPTABLE, desc = "Should produced exactly what was requested")
 	@State
 	public static class RequestAndProduceStressTest2 extends FluxSwitchMapStressTest {

diff --git a/...core/src/jcstress/java/reactor/core/publisher/FluxSwitchOnFirstConditionalStressTest.java b/...core/src/jcstress/java/reactor/core/publisher/FluxSwitchOnFirstConditionalStressTest.java
@@ -56,7 +56,8 @@ public abstract class FluxSwitchOnFirstConditionalStressTest {
 	abstract Flux<String> switchOnFirst(Signal<? extends String> signal,
 			Flux<String> inbound);
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {"1, 1, 1, 1, 1"}, expect = ACCEPTABLE)
 	@State
 	public static class OutboundOnSubscribeAndRequestStressTest
@@ -95,7 +96,8 @@ public void arbiter(LLLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"1, 2, 0, 1"}, expect = ACCEPTABLE, desc = "inbound next with error happens first")
 	@Outcome(id = {
@@ -143,7 +145,8 @@ public void arbiter(LLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"1, 1, 2, 1, 1"}, expect = ACCEPTABLE, desc = "outbound cancel happened before inbound next")
 	@Outcome(id = {

diff --git a/reactor-core/src/jcstress/java/reactor/core/publisher/FluxSwitchOnFirstStressTest.java b/reactor-core/src/jcstress/java/reactor/core/publisher/FluxSwitchOnFirstStressTest.java
@@ -57,7 +57,8 @@ public abstract class FluxSwitchOnFirstStressTest {
 	abstract Flux<String> switchOnFirst(Signal<? extends String> signal,
 			Flux<String> inbound);
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {"1, 1, 1, 1, 1"}, expect = ACCEPTABLE)
 	@State
 	public static class OutboundOnSubscribeAndRequestStressTest
@@ -96,7 +97,8 @@ public void arbiter(LLLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"0, 0, 1, 2, 2, 0, 1, 1, 0"}, expect = ACCEPTABLE, desc = "Inbound got second request, delivered onNext('value') and delivered onComplete() before cancellation")
 	@Outcome(id = {
@@ -168,7 +170,8 @@ public void arbiter(LLLLLLLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"0, 0, 1, 2, 2, 0, 2, 1, 0"}, expect = ACCEPTABLE, desc = "Inbound got second request, delivered onNext('value') and delivered onError() before cancellation")
 	@Outcome(id = {
@@ -241,7 +244,8 @@ public void arbiter(LLLLLLLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"1, 2, 0, 1"}, expect = ACCEPTABLE, desc = "inbound next with error happens first")
 	@Outcome(id = {
@@ -290,7 +294,8 @@ public void arbiter(LLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"0, 2, 0, 0"}, expect = ACCEPTABLE, desc = "inbound error with transformation error happens first")
 	@Outcome(id = {
@@ -340,7 +345,8 @@ public void arbiter(LLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"0, 2, 0, 0"}, expect = ACCEPTABLE, desc = "inbound complete with transformation error happens first")
 	@Outcome(id = {
@@ -390,7 +396,8 @@ public void arbiter(LLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"0, 0, 1, 2, 2, 1, 0, 1, 0"}, expect = ACCEPTABLE, desc = "inbound request happened first. then inbound cancel. then outbound cancel")
 	@Outcome(id = {
@@ -464,7 +471,8 @@ public void arbiter(LLLLLLLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"1, 1, 2, 1, 1"}, expect = ACCEPTABLE, desc = "outbound cancel happened before inbound next")
 	@Outcome(id = {
@@ -525,7 +533,8 @@ public void arbiter(LLLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"1, 0, 1, 1, 0"}, expect = ACCEPTABLE, desc = "inbound complete happened before outbound cancel")
 	@Outcome(id = {
@@ -586,7 +595,8 @@ public void arbiter(LLLLL_Result result) {
 		}
 	}
 
-	@JCStressTest
+	// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3627)
+	//@JCStressTest
 	@Outcome(id = {
 			"1, 0, 2, 1, 0"}, expect = ACCEPTABLE, desc = "inbound error happened before outbound cancel")
 	@Outcome(id = {