Skip to content

Commit

Permalink
Review feedback - comments added
Browse files Browse the repository at this point in the history
  • Loading branch information
chemicL committed Apr 30, 2024
1 parent 8e707bb commit 1b3232d
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 1 deletion.
Expand Up @@ -68,6 +68,7 @@ public String stepName() {

@Override
public final CoreSubscriber<? super I> subscribeOrReturn(CoreSubscriber<? super O> actual) {
// No need to wrap actual for CP, the Operators$LiftFunction handles it.
CoreSubscriber<? super I> input = liftFunction.lifter.apply(source, actual);

Objects.requireNonNull(input, "Lifted subscriber MUST NOT be null");
Expand Down
Expand Up @@ -70,6 +70,7 @@ public String stepName() {

@Override
public final CoreSubscriber<? super I> subscribeOrReturn(CoreSubscriber<? super O> actual) {
// No need to wrap actual for CP, the Operators$LiftFunction handles it.
CoreSubscriber<? super I> input = liftFunction.lifter.apply(source, actual);

Objects.requireNonNull(input, "Lifted subscriber MUST NOT be null");
Expand Down
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2016-2024 VMware Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2024 VMware Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
Expand Up @@ -79,6 +79,7 @@ public String stepName() {

@Override
public void subscribe(CoreSubscriber<? super O> actual) {
// No need to wrap actual for CP, the Operators$LiftFunction handles it.
CoreSubscriber<? super I> input = liftFunction.lifter.apply(source, actual);

Objects.requireNonNull(input, "Lifted subscriber MUST NOT be null");
Expand Down
Expand Up @@ -81,6 +81,7 @@ public String stepName() {

@Override
public void subscribe(CoreSubscriber<? super O> actual) {
// No need to wrap actual for CP, the Operators$LiftFunction handles it.
CoreSubscriber<? super I> input = liftFunction.lifter.apply(source, actual);

Objects.requireNonNull(input, "Lifted subscriber MUST NOT be null");
Expand Down
Expand Up @@ -37,6 +37,7 @@ final class MonoLift<I, O> extends InternalMonoOperator<I, O> {

@Override
public CoreSubscriber<? super I> subscribeOrReturn(CoreSubscriber<? super O> actual) {
// No need to wrap actual for CP, the Operators$LiftFunction handles it.
CoreSubscriber<? super I> input = liftFunction.lifter.apply(source, actual);

Objects.requireNonNull(input, "Lifted subscriber MUST NOT be null");
Expand Down
Expand Up @@ -55,6 +55,7 @@ public Object scanUnsafe(Attr key) {

@Override
public CoreSubscriber<? super I> subscribeOrReturn(CoreSubscriber<? super O> actual) {
// No need to wrap actual for CP, the Operators$LiftFunction handles it.
CoreSubscriber<? super I> input = liftFunction.lifter.apply(source, actual);

Objects.requireNonNull(input, "Lifted subscriber MUST NOT be null");
Expand Down
Expand Up @@ -84,6 +84,7 @@ public void subscribe(CoreSubscriber<? super O>[] s) {
int i = 0;
while (i < subscribers.length) {
subscribers[i] =
// No need to wrap actual for CP, the Operators$LiftFunction handles it.
Objects.requireNonNull(liftFunction.lifter.apply(source, s[i]),
"Lifted subscriber MUST NOT be null");
i++;
Expand Down
Expand Up @@ -88,6 +88,7 @@ public void subscribe(CoreSubscriber<? super O>[] s) {
while (i < subscribers.length) {
CoreSubscriber<? super O> actual = s[i];
CoreSubscriber<? super I> converted =
// No need to wrap actual for CP, the Operators$LiftFunction handles it.
Objects.requireNonNull(liftFunction.lifter.apply(source, actual), "Lifted subscriber MUST NOT be null");

Objects.requireNonNull(converted, "Lifted subscriber MUST NOT be null");
Expand Down

0 comments on commit 1b3232d

Please sign in to comment.