Code polishing (#3234)

This commit consist of several small code polishing, mostly in Flux:
 - vestigial SuppressWarnings
 - vestigial method type parameters (safe to remove according
to JLS 13.4.13. Method and Constructor Type Parameters)
 - turning an URL from http to https

README.md

@@ -214,6 +214,6 @@ https://github.com/reactor/head-first-reactive-with-spring-and-reactor/
 -------------------------------------
 _Powered by [Reactive Streams Commons](https://github.com/reactor/reactive-streams-commons)_
 
-_Licensed under [Apache Software License 2.0](www.apache.org/licenses/LICENSE-2.0)_
+_Licensed under [Apache Software License 2.0](https://www.apache.org/licenses/LICENSE-2.0)_
 
 _Sponsored by [VMware](https://tanzu.vmware.com/)_

reactor-core/src/main/java/reactor/core/publisher/Flux.java

@@ -396,7 +396,7 @@ public static <T, V> Flux<V> combineLatest(Iterable<? extends Publisher<? extend
 			int prefetch,
 			Function<Object[], V> combinator) {
 
-		return onAssembly(new FluxCombineLatest<T, V>(sources,
+		return onAssembly(new FluxCombineLatest<>(sources,
 				combinator,
 				Queues.get(prefetch), prefetch));
 	}
@@ -2397,10 +2397,10 @@ public static <O> Flux<O> zip(Iterable<? extends Publisher<?>> sources,
 			int prefetch,
 			final Function<? super Object[], ? extends O> combinator) {
 
-		return onAssembly(new FluxZip<Object, O>(sources,
-				combinator,
-				Queues.get(prefetch),
-				prefetch));
+		return onAssembly(new FluxZip<>(sources,
+			combinator,
+			Queues.get(prefetch),
+			prefetch));
 	}
 
 	/**
@@ -3050,7 +3050,7 @@ public final Flux<List<T>> bufferUntil(Predicate<? super T> predicate, boolean c
 	 *
 	 * @return a microbatched {@link Flux} of {@link List}
 	 */
-	public final <V> Flux<List<T>> bufferUntilChanged() {
+	public final Flux<List<T>> bufferUntilChanged() {
 		return bufferUntilChanged(identityFunction());
 	}
 
@@ -3718,7 +3718,6 @@ public final Mono<List<T>> collectSortedList() {
 	 *
 	 * @return a {@link Mono} of a sorted {@link List} of all values from this {@link Flux}
 	 */
-	@SuppressWarnings({ "unchecked", "rawtypes" })
 	public final Mono<List<T>> collectSortedList(@Nullable Comparator<? super T> comparator) {
 		return collectList().doOnNext(list -> {
 			// Note: this assumes the list emitted by buffer() is mutable
@@ -4021,7 +4020,6 @@ public final <R> Flux<R> concatMapIterable(Function<? super T, ? extends Iterabl
 	 */
 	public final Flux<T> concatWith(Publisher<? extends T> other) {
 		if (this instanceof FluxConcatArray) {
-			@SuppressWarnings({ "unchecked" })
 			FluxConcatArray<T> fluxConcatArray = (FluxConcatArray<T>) this;
 
 			return fluxConcatArray.concatAdditionalSourceLast(other);
@@ -5997,7 +5995,6 @@ public final Mono<T> last(T defaultValue) {
 		    @SuppressWarnings("unchecked")
 		    Callable<T> thiz = (Callable<T>)this;
 		    if(thiz instanceof Fuseable.ScalarCallable){
-		    	@SuppressWarnings("unchecked")
 			    Fuseable.ScalarCallable<T> c = (Fuseable.ScalarCallable<T>)thiz;
 			    T v;
 			    try {
@@ -9201,7 +9198,6 @@ public final Mono<Void> thenEmpty(Publisher<Void> other) {
 	 */
 	public final <V> Flux<V> thenMany(Publisher<V> other) {
 		if (this instanceof FluxConcatArray) {
-			@SuppressWarnings({ "unchecked" })
 			FluxConcatArray<T> fluxConcatArray = (FluxConcatArray<T>) this;
 			return fluxConcatArray.concatAdditionalIgnoredLast(other);
 		}
@@ -9391,7 +9387,7 @@ public final <U, V> Flux<T> timeout(Publisher<U> firstTimeout,
 		return timeout(firstTimeout, nextTimeoutFactory, "first signal from a Publisher");
 	}
 
-	private final <U, V> Flux<T> timeout(Publisher<U> firstTimeout,
+	private <U, V> Flux<T> timeout(Publisher<U> firstTimeout,
 			Function<? super T, ? extends Publisher<V>> nextTimeoutFactory,
 			String timeoutDescription) {
 			return onAssembly(new FluxTimeout<>(this, firstTimeout, nextTimeoutFactory, timeoutDescription));
@@ -10224,7 +10220,7 @@ public final Flux<Flux<T>> windowUntil(Predicate<T> boundaryTrigger, boolean cut
 	 *
 	 * @return a microbatched {@link Flux} of {@link Flux} windows.
 	 */
-	public final <V> Flux<Flux<T>> windowUntilChanged() {
+	public final Flux<Flux<T>> windowUntilChanged() {
 		return windowUntilChanged(identityFunction());
 	}
 
@@ -10489,7 +10485,6 @@ public final <T2> Flux<Tuple2<T, T2>> zipWith(Publisher<? extends T2> source2) {
 	public final <T2, V> Flux<V> zipWith(Publisher<? extends T2> source2,
 			final BiFunction<? super T, ? super T2, ? extends V> combinator) {
 		if (this instanceof FluxZip) {
-			@SuppressWarnings("unchecked")
 			FluxZip<T, V> o = (FluxZip<T, V>) this;
 			Flux<V> result = o.zipAdditionalSource(source2, combinator);
 			if (result != null) {
@@ -10561,7 +10556,6 @@ public final <T2> Flux<Tuple2<T, T2>> zipWith(Publisher<? extends T2> source2, i
 	 * @return a zipped {@link Flux}
 	 *
 	 */
-	@SuppressWarnings("unchecked")
 	public final <T2> Flux<Tuple2<T, T2>> zipWithIterable(Iterable<? extends T2> iterable) {
 		return zipWithIterable(iterable, tuple2Function());
 	}
@@ -10663,7 +10657,6 @@ final <R> Flux<R> flatMapSequential(Function<? super T, ? extends
 				FluxConcatMap.ErrorMode.IMMEDIATE));
 	}
 
-	@SuppressWarnings("unchecked")
 	static <T> Flux<T> doOnSignal(Flux<T> source,
 			@Nullable Consumer<? super Subscription> onSubscribe,
 			@Nullable Consumer<? super T> onNext,
@@ -10866,6 +10859,7 @@ static <I> Flux<I> wrap(Publisher<? extends I> source) {
 	@SuppressWarnings("rawtypes")
 	static final Supplier        SET_SUPPLIER            = HashSet::new;
 	static final BooleanSupplier ALWAYS_BOOLEAN_SUPPLIER = () -> true;
+	@SuppressWarnings("rawtypes")
 	static final BiPredicate     OBJECT_EQUAL            = Object::equals;
 	@SuppressWarnings("rawtypes")
 	static final Function        IDENTITY_FUNCTION       = Function.identity();