various minor cleanups #3234
Merged
various minor cleanups #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
approved these changes
Oct 26, 2022
simonbasle
added
the
type/chores
simonbasle
approved these changes
Oct 26, 2022
| @@ -3050,7 +3050,7 @@ public final Flux<List<T>> bufferUntil(Predicate<? super T> predicate, boolean c | |||
| * | |||
| * @return a microbatched {@link Flux} of {@link List} | |||
| */ | |||
| public final <V> Flux<List<T>> bufferUntilChanged() { | |||
| public final Flux<List<T>> bufferUntilChanged() { | |||
There was a problem hiding this comment.
even though I was assuming japicmp would complain if this was an issue, I double checked with the JLS that this is indeed fine. for my own reference: https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html
13.4.13. Method and Constructor Type Parameters
Adding or removing a type parameter of a method or constructor does not, in itself, have any implications for binary compatibility.
If such a type parameter is used in the type of the method or constructor, that may have the normal implications of changing the aforementioned type.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello :)
while studying the sources, I just found some minor problems (unused suppress "unchecked", some missed java7 migrations).