Context propagation: use new APIs from latest snapshots #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
simonbasle
commented
Oct 27, 2022
simonbasle
commented
- Depend on post-RC1 snapshots of context-propagation
- Use ContextSnapshot.setAllThreadLocalsFrom
- Remove registry and intermediary classes, use Supplier
With the introduction of removal methods in ContextRegistry, it becomes more practical to use the ContextRegistry.getInstance global instance. Following that, two of the three intermediate classes are no longer needed and can be replaced with lambdas: ContextCaptureFunction and ContextRestoreHandleConsumer. Instead of calling the ContextPropagation methods with a subscriber (which necessitates some mocking in tests), we now take a Supplier of Context. A CoreSubscriber::currentContext method reference can do the trick in production code.
simonbasle
added
area/context
OlegDokuka
approved these changes
Oct 31, 2022
OlegDokuka
reviewed
Oct 31, 2022
| } | ||
|
|
||
| static <T, R> BiConsumer<T, SynchronousSink<R>> contextRestoreForHandle(BiConsumer<T, SynchronousSink<R>> handler, CoreSubscriber<? super R> actual) { | ||
| if (!ContextPropagation.isContextPropagationAvailable() || actual.currentContext().isEmpty()) { | ||
| static <T, R> BiConsumer<T, SynchronousSink<R>> contextRestoreForHandle(BiConsumer<T, SynchronousSink<R>> handler, Supplier<Context> contextSupplier) { |
There was a problem hiding this comment.
just a small comment that the supplier can be overhead for the mono case since one extra object is allocated per subscriber * per operator. I guess that the goal was to avoid context retrieval if there is no need, but not sure what brings more impact.
There was a problem hiding this comment.
I think this is fine since the Supplier in the hot path is CoreSubscriber::currentContext (ie. a method reference).
simonbasle
changed the title
|
Late LGTM 👍 |
|
this also fixes #3244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.