Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat specification for use with repeatWhen operator #3545

Open
chemicL opened this issue Jul 26, 2023 · 5 comments
Open

Repeat specification for use with repeatWhen operator #3545

chemicL opened this issue Jul 26, 2023 · 5 comments
Assignees
Labels
good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement
Milestone

Comments

@chemicL
Copy link
Member

chemicL commented Jul 26, 2023

Similarly to the way Retry is implemented with accompanying retryWhen(RetrySpec) operator, the Repeat functionality from reactor-addons project should be implemented in reactor-core and phased out from reactor-extras (module of reactor-addons). It can potentially reuse the primitives that already exist for the retry functionality.

@chemicL chemicL added type/enhancement A general enhancement good first issue Ideal for a new contributor, we'll help labels Jul 26, 2023
@chemicL chemicL added this to the 3.6 planning milestone Jul 26, 2023
@Desislav-Petrov
Copy link

Hi @chemicL - i'm keen to explore this one - could you please assign to me? Thanks

@Desislav-Petrov
Copy link

hi @chemicL - i was looking at how the retry has been ported from addons to the core as an inspiration for the repeat. Looks like the port hasn't been exactly 1;1 in terms of functionality so I assume that will be the case for repeat as well. Do we need to preserve all the functionality that's currently offered by the addons repeat? Any guidance will be appreciated.

@chemicL
Copy link
Member Author

chemicL commented Aug 10, 2023

@OlegDokuka can you please respond when you find a moment? (I'm going to be away for a few days)

@OlegDokuka
Copy link
Contributor

@Desislav-Petrov we don't literally have to port impl from reactor-addons but rather create a shared common for both retry and repeat operators. That means the logic implemented in Retry builder can go into something like "CommonRecurring" (or whatever name we endup) and then implement Repeat builder having that base mechanism as well as Retry.

@Desislav-Petrov
Copy link

Got you - thanks, will have a go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants