Establishing approach #3593
Open
Establishing approach #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Desislav-Petrov Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
1 similar comment
|
@Desislav-Petrov Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Desislav-Petrov Thank you for signing the Contributor License Agreement! |
Desislav-Petrov
commented
Oct 1, 2023
| .concatMap(retryWhenState -> { | ||
| RepeatSignal copy = retryWhenState.copy(); | ||
| long iteration = copy.getRepeatsSoFar(); | ||
| if (iteration > repeats) { |
There was a problem hiding this comment.
I don't think this is the most graceful way to do this, was trying to get some inspiration from the Retry one but the case is slightly different there
Desislav-Petrov
force-pushed
the
repeat_uplift
branch
from
88acec7
to
ab0d08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @chemicL and @OlegDokuka - kicked off some work for #3545 but wanted to verify the approach before i go any further.
So my plan is as follows.