Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cancel too synchronized in MonoCollect[List] #3053

Merged
merged 5 commits into from
Jun 7, 2022
Merged

Fix cancel too synchronized in MonoCollect[List] #3053

merged 5 commits into from
Jun 7, 2022

Commits on May 24, 2022

  1. Reduce MonoCollectList cancel() synchronized block 

    This commit reduces the length of the critical section in cancel() that
is synchronized. In particular, it removes upstream cancel() from said
critical section. This will prevent a deadlock in case the upstream
operator itself uses synchronized block between cancel() and methods
that call any of this subscriber's synchronized methods (eg. onNext).

Fixes #3052.
    @simonbasle
    simonbasle committed May 24, 2022
    Configuration menu
    Copy the full SHA
    19be511 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. also fix MonoCollect, make synchronized block even shorter

    @simonbasle
    simonbasle committed May 25, 2022
    Configuration menu
    Copy the full SHA
    7c7dc2e View commit details
    Browse the repository at this point in the history

  2. cancellation could be propagated after list is erased, try less loops

    @simonbasle
    simonbasle committed May 25, 2022
    Configuration menu
    Copy the full SHA
    8c6260a View commit details
    Browse the repository at this point in the history

  3. reduce number of loops, global test timeout at 30s

    @simonbasle
    simonbasle committed May 25, 2022
    Configuration menu
    Copy the full SHA
    a1bf083 View commit details
    Browse the repository at this point in the history

  4. revert move of cancel propagation after nulling out

    @simonbasle
    simonbasle committed May 25, 2022
    Configuration menu
    Copy the full SHA
    4e57918 View commit details
    Browse the repository at this point in the history