Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TimedScheduler to reactor-core-micrometer module #3109

Merged
merged 21 commits into from
Aug 4, 2022
Merged

Add TimedScheduler to reactor-core-micrometer module #3109

merged 21 commits into from
Aug 4, 2022

Commits on Jul 7, 2022

  1. Add TimedScheduler to reactor-core-micrometer module

    @simonbasle
    simonbasle committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b8ccf73 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. make TimedScheduler package-private

    @simonbasle
    simonbasle committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    c1ad1e9 View commit details
    Browse the repository at this point in the history

  2. remove TimedScheduler schedulerName, only use meterPrefix

    @simonbasle
    simonbasle committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    28bf7eb View commit details
    Browse the repository at this point in the history

  3. add Micrometer#timedScheduler javadoc

    @simonbasle
    simonbasle committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    1694fc8 View commit details
    Browse the repository at this point in the history

  4. [BREAKING] Remove enable/disableSchedulerMetricsDecorator

    @simonbasle
    simonbasle committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    2c7341c View commit details
    Browse the repository at this point in the history

  5. update the deprecation notice in Schedulers

    @simonbasle
    simonbasle committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    9eafbc1 View commit details
    Browse the repository at this point in the history

  6. merge main to get latest changes like observation()

    @simonbasle
    simonbasle committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    472c74f View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. polish meters, add tests

    @simonbasle
    simonbasle committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    d5b0ed9 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Refactor TimedScheduler to use LongTaskTimers and Counters

    @simonbasle
    simonbasle committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    5220d2f View commit details
    Browse the repository at this point in the history

  2. WIP add counter for periodical re-runs

    @simonbasle
    simonbasle committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    97795a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Merge latest changes from 'main' (removing Clock/common registry)

    @simonbasle
    simonbasle committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    e45955e View commit details
    Browse the repository at this point in the history

  2. Merge 'main': fixing compilation issues

    @simonbasle
    simonbasle committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    ab23d35 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @simonbasle
    simonbasle committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    73a76ce View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. rework 4 counters: same name, tag differentiator

    @simonbasle
    simonbasle committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    1ed20ee View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. fix Micrometer test now that we've added a tag

    @simonbasle
    simonbasle committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    8e28a86 View commit details
    Browse the repository at this point in the history

  2. fix review comments, notably 'periodic' wording

    @simonbasle
    simonbasle committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    dc35b4d View commit details
    Browse the repository at this point in the history

  3. move tests from confusing case TimedSchedulerTest to SingleSchedulerT… 

    …est in core

an old test in core is named `TimedSchedulerTest`. This is confusing now
that there is an actual `TimedScheduler`. Since this test class uses the
SingleScheduler its two tests have been moved to `SingleSchedulerTest`
(and slightly amended to use `afterTest` extension).
    @simonbasle
    simonbasle committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    8859f80 View commit details
    Browse the repository at this point in the history

  4. fix review comments in tests, except slow tests

    @simonbasle
    simonbasle committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    447cd7e View commit details
    Browse the repository at this point in the history

  5. use MockClock to assert precise timings of active vs pending durations

    @simonbasle
    simonbasle committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    34b3873 View commit details
    Browse the repository at this point in the history

  6. review: use mock instead of spy

    @simonbasle
    simonbasle committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    505e58c View commit details
    Browse the repository at this point in the history

  7. polish: close registry afterEach test, fix 1 license header

    @simonbasle
    simonbasle committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    a42b8f3 View commit details
    Browse the repository at this point in the history