Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging in Exceptions.throwIf[Jvm]Fatal, add isFatal methods #3122

Merged
merged 7 commits into from Aug 1, 2022

Commits on Aug 1, 2022

  1. Add logging in Exceptions.throwIf[Jvm]Fatal, add isFatal methods

    This commit improves the discoverability of exceptions that are "fatal"
    to Reactor by:
     - adding `Exceptions.isFatal` and `Exceptions.isJvmFatal` methods
     - adding logging to `Exceptions.throwIfFatal` and
     `Exceptions.throwIfJvmFatal` just before a fatal exception is thrown
    
    This should at least help pinpointing such occurrences from the logs,
    in cases where the thrown exception bubble all the way up the stack of
    a thread with no uncaughtExceptionHandler for example.
    
    Fixes #3111.
    simonbasle committed Aug 1, 2022
    Copy the full SHA
    5a2109b View commit details
    Browse the repository at this point in the history
  2. fix license

    simonbasle committed Aug 1, 2022
    Copy the full SHA
    3abc222 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    988b16e View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    b663215 View commit details
    Browse the repository at this point in the history
  5. fix leftover import

    simonbasle committed Aug 1, 2022
    Copy the full SHA
    31912b1 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    7c93a85 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    03ea8b2 View commit details
    Browse the repository at this point in the history