Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Micrometer#useRegistry, remove notion of Clock #3128

Merged
merged 1 commit into from Jul 27, 2022
Merged

Remove Micrometer#useRegistry, remove notion of Clock #3128

merged 1 commit into from Jul 27, 2022

Conversation

simonbasle
Copy link
Member

@simonbasle simonbasle commented Jul 25, 2022 •
edited

This PR depends on #3127 as it builds on top of the scheduler-related breaking changes.

It breaks the reactor-core-micrometer Micrometer API introduced in previous
milestones:

  • remove useRegistry and the notion of a default global registry
  • remove metrics() and metrics(MeterRegistry, Clock)
  • replace the above by metrics(MeterRegistry) (as the Clock can be provided through the MeterRegistry#config())

@simonbasle simonbasle added this to the 3.5.0-M5 milestone Jul 25, 2022
@simonbasle simonbasle added area/observability type/enhancement A general enhancement warn/api-change Breaking change with compilation errors labels Jul 25, 2022
@simonbasle simonbasle self-assigned this Jul 25, 2022
@simonbasle simonbasle requested a review from a team July 25, 2022 17:13
@simonbasle simonbasle changed the title [BREAKING] remove Micrometer registry, remove notion of Clock [BREAKING from M4] remove Micrometer registry, remove notion of Clock Jul 25, 2022
@simonbasle simonbasle force-pushed the micrometerRemoveGlobalRegistryAndClock branch from 32825ee to 2bb140f Compare July 26, 2022 14:47
@simonbasle simonbasle changed the base branch from micrometerInstrumentedScheduler to main July 26, 2022 14:47
@simonbasle
Copy link
Member Author

rebased on top of and amended to target main branch

@simonbasle simonbasle marked this pull request as ready for review July 26, 2022 14:48
@simonbasle simonbasle requested a review from a team as a code owner July 26, 2022 14:48
@simonbasle simonbasle changed the title [BREAKING from M4] remove Micrometer registry, remove notion of Clock Remove Micrometer#useRegistry, remove notion of Clock Jul 27, 2022
@simonbasle simonbasle merged commit 687fdf8 into main Jul 27, 2022
@simonbasle simonbasle deleted the micrometerRemoveGlobalRegistryAndClock branch July 27, 2022 10:14
@simonbasle simonbasle mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@violetagg violetagg violetagg approved these changes

Assignees

@simonbasle simonbasle

Labels
area/observability type/enhancement A general enhancement warn/api-change Breaking change with compilation errors
Projects
None yet
Milestone
3.5.0-M5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonbasle @violetagg