Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use byte padding to avoid fields re-ordering on JDK 15 and above #3168

Merged
merged 12 commits into from
Aug 29, 2022
Merged

Use byte padding to avoid fields re-ordering on JDK 15 and above #3168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9a0f4ff
Replace 'long' padding by 'byte' padding to avoid re-ordering on mode…
lantalex Aug 24, 2022
65747a9
Update license header
lantalex Aug 25, 2022
fc14627
Replace 'long' padding for QueueDrainSubscriber
lantalex Aug 26, 2022
f381459
Replace the QueueDrainSubscriber#objectLayout() test with the simplif…
lantalex Aug 26, 2022
f23ab52
Use 'pad' prefix for padding field names
lantalex Aug 26, 2022
0eba668
Add object layout test for SpscArrayQueue
lantalex Aug 26, 2022
3d8ef21
Extend padding for QueueDrainSubscriber + update test
lantalex Aug 28, 2022
ab0fa1d
Making SpscArrayQueue internal padding consistent for actual versions…
lantalex Aug 28, 2022
c58af9d
Fix alignment
lantalex Aug 29, 2022
915a8b4
Add `unused` annotation for padding fields
lantalex Aug 29, 2022
4420d41
Add `unused` annotation for padding fields
lantalex Aug 29, 2022
463c559
Remove unnecessary `public` modifier
lantalex Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion reactor-core/src/test/java/reactor/core/publisher/QueueDrainSubscriberTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ public void objectPadding() {
"error"
);

assertThat(paddingSizes).containsExactly(120L, 128L, 128L);
assertThat(paddingSizes).containsExactly(128L, 128L, 128L);
}
}
4 changes: 2 additions & 2 deletions reactor-core/src/test/java/reactor/util/concurrent/SpscArrayQueueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public void shouldNotRemoveElementOnPeek() {

@Test
@Tag("slow")
void objectPadding() {
public void objectPadding() {
lantalex marked this conversation as resolved.
Show resolved Hide resolved
ClassLayout layout = ClassLayout.parseClass(SpscArrayQueue.class);

AtomicLong currentPaddingSize = new AtomicLong();
Expand Down Expand Up @@ -162,6 +162,6 @@ void objectPadding() {
"[padding]"
);

assertThat(paddingSizes).containsExactly(124L, 128L, 128L);
assertThat(paddingSizes).containsExactly(132L, 128L, 128L);
lantalex marked this conversation as resolved.
Show resolved Hide resolved
}
}