Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecates onNextDropped and supersedes it by onDiscard with reason and value #3229

Closed
wants to merge 1 commit into from

Conversation

OlegDokuka
Copy link
Contributor

closes #2103

Signed-off-by: Oleh Dokuka odokuka@vmware.com

@OlegDokuka OlegDokuka added type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations area/doOnDiscard This belongs to the doOnDiscard theme labels Oct 11, 2022
…d value

Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
@OlegDokuka
Copy link
Contributor Author

@simonbasle @chemicL not sure about the new API naming since it causes part of tests failing

@OlegDokuka OlegDokuka requested a review from a team October 12, 2022 07:21
@OlegDokuka
Copy link
Contributor Author

superseded by #3240

@OlegDokuka OlegDokuka closed this Oct 19, 2022
@simonbasle simonbasle mentioned this pull request Oct 19, 2022
@chemicL chemicL deleted the deprecation/on-next-drop branch April 11, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doOnDiscard This belongs to the doOnDiscard theme type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discard vs. Drop
1 participant