-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the number of Scheduler#disposeGracefully threads #3259
Merged
Commits on Oct 28, 2022
-
Limit the number of Scheduler#disposeGracefully threads
This change modifies the `DisposeAwaiter` interface in order to be able to poll for graceful shutdown termination status rather than await/block for it. It introduces a DisposeAwaiterRunnable with a small pool of threads dedicated to polling the termination status after a graceful Scheduler shutdown. Previously, one Thread would be created for each Scheduler that is disposed gracefully. While we don't expect this to be an issue in most production applications, this can lead to hitting native thread limits faster. Notably, stress tests around graceful disposal create a lot of schedulers for that purpose.
Configuration menu - View commit details
-
Copy full SHA for dbb6ad4 - Browse repository at this point
Copy the full SHA dbb6ad4View commit details
Commits on Nov 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4e022d5 - Browse repository at this point
Copy the full SHA 4e022d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 923bad2 - Browse repository at this point
Copy the full SHA 923bad2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 648c04a - Browse repository at this point
Copy the full SHA 648c04aView commit details
Commits on Nov 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ead69be - Browse repository at this point
Copy the full SHA ead69beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72673da - Browse repository at this point
Copy the full SHA 72673daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e1b840 - Browse repository at this point
Copy the full SHA 8e1b840View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9aa046 - Browse repository at this point
Copy the full SHA e9aa046View commit details -
Configuration menu - View commit details
-
Copy full SHA for c18f82a - Browse repository at this point
Copy the full SHA c18f82aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 044fdb0 - Browse repository at this point
Copy the full SHA 044fdb0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.