-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes incorrect value/error set during tryEmitXXX
call
#3260
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
112 changes: 112 additions & 0 deletions
112
reactor-core/src/jcstress/java/reactor/core/publisher/SinkOneStressTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,112 @@ | ||
/* | ||
* Copyright (c) 2020-2022 VMware Inc. or its affiliates, All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package reactor.core.publisher; | ||
|
||
import org.openjdk.jcstress.annotations.Actor; | ||
import org.openjdk.jcstress.annotations.Arbiter; | ||
import org.openjdk.jcstress.annotations.JCStressTest; | ||
import org.openjdk.jcstress.annotations.Outcome; | ||
import org.openjdk.jcstress.annotations.State; | ||
import org.openjdk.jcstress.infra.results.LLL_Result; | ||
import org.openjdk.jcstress.infra.results.LL_Result; | ||
|
||
import static org.openjdk.jcstress.annotations.Expect.ACCEPTABLE; | ||
|
||
public class SinkOneStressTest { | ||
|
||
@JCStressTest | ||
@Outcome(id = {"foo, 1"}, expect = ACCEPTABLE, desc = "value delivered") | ||
@State | ||
public static class EmitValueSubscribeStressTest extends SinkOneStressTest { | ||
|
||
final SinkOneMulticast<String> sink = new SinkOneMulticast<>(); | ||
final StressSubscriber<String> subscriber = new StressSubscriber<>(); | ||
|
||
@Actor | ||
public void value() { | ||
sink.tryEmitValue("foo"); | ||
sink.tryEmitEmpty(); | ||
sink.tryEmitError(new RuntimeException()); | ||
} | ||
|
||
@Actor | ||
public void subscriber() { | ||
sink.asMono().subscribe(subscriber); | ||
} | ||
|
||
@Arbiter | ||
public void arbiter(LL_Result r) { | ||
r.r1 = subscriber.onNextCalls.get() == 1 ? subscriber.receivedValues.get(0) : null; | ||
r.r2 = subscriber.onCompleteCalls.get(); | ||
} | ||
} | ||
|
||
@JCStressTest | ||
@Outcome(id = {"null, 1"}, expect = ACCEPTABLE, desc = "value delivered") | ||
@State | ||
public static class EmitEmptySubscribeStressTest extends SinkOneStressTest { | ||
|
||
final SinkOneMulticast<String> sink = new SinkOneMulticast<>(); | ||
final StressSubscriber<String> subscriber = new StressSubscriber<>(); | ||
|
||
@Actor | ||
public void value() { | ||
sink.tryEmitEmpty(); | ||
sink.tryEmitValue("foo"); | ||
sink.tryEmitError(new RuntimeException()); | ||
} | ||
|
||
@Actor | ||
public void subscriber() { | ||
sink.asMono().subscribe(subscriber); | ||
} | ||
|
||
@Arbiter | ||
public void arbiter(LL_Result r) { | ||
r.r1 = subscriber.onNextCalls.get() == 1 ? subscriber.receivedValues.get(0) : null; | ||
r.r2 = subscriber.onCompleteCalls.get(); | ||
} | ||
} | ||
|
||
@JCStressTest | ||
@Outcome(id = {"null, 0, boo"}, expect = ACCEPTABLE, desc = "value delivered") | ||
@State | ||
public static class EmitErrorSubscribeStressTest extends SinkOneStressTest { | ||
|
||
final SinkOneMulticast<String> sink = new SinkOneMulticast<>(); | ||
final StressSubscriber<String> subscriber = new StressSubscriber<>(); | ||
|
||
@Actor | ||
public void value() { | ||
sink.tryEmitError(new RuntimeException("boo")); | ||
sink.tryEmitEmpty(); | ||
sink.tryEmitValue("foo"); | ||
} | ||
|
||
@Actor | ||
public void subscriber() { | ||
sink.asMono().subscribe(subscriber); | ||
} | ||
|
||
@Arbiter | ||
public void arbiter(LLL_Result r) { | ||
r.r1 = subscriber.onNextCalls.get() == 1 ? subscriber.receivedValues.get(0) : null; | ||
r.r2 = subscriber.onCompleteCalls.get(); | ||
r.r3 = subscriber.onErrorCalls.get() == 1 ? subscriber.error.getMessage() : null; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can there be a race now by which two threads write the value in the following order T1: v1, T2: v2; then T1 manages to win the CAS below, while value is set to v2? The previous behaviour prevented such an interleaving as the CAS happened first, although the publication was a problem, but now I'm uncertain about consistency, can you explain whether it's impossible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the goal of this implementation to cover such cases. Usafe Sink implementation is not covering concurrent invocation of the tryEmit methods