Add Mono.fromCompletionStage overrides suppressing cancellation #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, Mono::fromFuture operators were enhanced to support suppresion of subscription cancellation being propagated to the source Future. In case of CompletionStage, this overrides can be also useful, since cancelling the source was a behaviour change and users might need to default to the old behaviour.
chemicL
changed the title
violetagg
requested changes
Nov 2, 2022
| * <p> | ||
| * <img class="marble" src="doc-files/marbles/fromFuture.svg" alt=""> | ||
| * <p> | ||
| * Note, use {@link #fromFuture(CompletableFuture, boolean)} with {@code |
There was a problem hiding this comment.
Suggested change
| * Note, use {@link #fromFuture(CompletableFuture, boolean)} with {@code | |
| * Note, use {@link #fromCompletionStage(CompletableFuture, boolean)} with {@code |
| * <p> | ||
| * <img class="marble" src="doc-files/marbles/fromFutureSupplier.svg" alt=""> | ||
| * <p> | ||
| * Note, use {@link #fromFuture(CompletableFuture, boolean)} with {@code |
There was a problem hiding this comment.
Suggested change
| * Note, use {@link #fromFuture(CompletableFuture, boolean)} with {@code | |
| * Note, use {@link #fromCompletionStage(CompletableFuture, boolean)} with {@code |
simonbasle
requested changes
Nov 2, 2022
|
Closing. It does make sense when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Mono.fromFuture operators were enhanced to support suppresion of subscription cancellation being propagated to the source Future. In case of CompletionStage, this overrides can be also useful, since cancelling the source was a behaviour change and users might need to default to the old behaviour.
This is a follow-up from #3146 and #3252