Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issues/3340] bugfix concurrency issues FluxReplay.Size/SizeAndTime #3714

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[issues/3340] bugfix concurrency issues FluxReplay.Size/SizeAndTime #3714

wants to merge 6 commits into from
+444 −56

Commits on Mar 22, 2023

  1. [issue 3340] add test to verify no leak

    @MikkelHJuul
    MikkelHJuul committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    e53da64 View commit details
    Browse the repository at this point in the history

  2. [issue 3340] fix leak 

    finalize head and roll it over in stead of resetting head, this means the current head will always remain a value-null in stead of being reassigned.
I applied the fix for the TimeAndSizeBoundReplayBuffer
    @MikkelHJuul
    MikkelHJuul committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    6a7381e View commit details
    Browse the repository at this point in the history

  3. [issue 3340] add some tests

    @MikkelHJuul
    MikkelHJuul committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    3e3b2a0 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. [issue 3340] add stress tests

    @MikkelHJuul
    MikkelHJuul committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9b97757 View commit details
    Browse the repository at this point in the history

  2. [issue 3340] fix concurrency issues 

    in add: `head.get().get()` concurrently could trigger null-pointer
also: tail was contested and the tail would be silently dropped on write
    @MikkelHJuul
    MikkelHJuul committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    584f6e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. [issue 3340] when the limit is reached head must roll over 

    if head does not roll over, the cache may grow beyond its limit
    @MikkelHJuul
    MikkelHJuul committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a7f6df3 View commit details
    Browse the repository at this point in the history