Improve auto context propagation in lifting and ConnectableFlux intersection #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemicL
added
type/bug
violetagg
requested changes
Apr 24, 2024
...core/src/main/java/reactor/core/publisher/FluxContextWriteRestoringThreadLocalsFuseable.java
Outdated
Show resolved
Hide resolved
reactor-core/src/main/java/reactor/core/publisher/ConnectableLiftFuseable.java
Show resolved
Hide resolved
reactor-core/src/main/java/reactor/core/publisher/GroupedLiftFuseable.java
Show resolved
Hide resolved
reactor-core/src/main/java/reactor/core/publisher/ParallelLiftFuseable.java
Show resolved
Hide resolved
violetagg
approved these changes
Apr 30, 2024
|
@violetagg thank you for the review! |
chemicL
added a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining ConnectableFlux or Fuseable operators and wrapping via Hooks could lead to ClassCastException or lack of ThreadLocal restoration. ConnectableFlux and Fuseable handling has been improved. Also, lifting now avoids unnecessary multiple-wrapping.
Fixes #3762