Stabilize HttpMetricsHandlerTests#testServerConnectionsRecorder #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pderop
changed the title
… by BaseHttpTest.disposeServer method.
|
@violetagg , please hold on before reviewing, I may have to cleanup something before. thanks. |
|
@violetagg, the cleanup I had in mind does not work for the moment, so can you please review ? |
…verCloseHandler in order to ensure the server has closed the client socket
…lMetricsHandler if H2 is used.
violetagg
requested changes
Jul 13, 2022
| }, | ||
| Function.identity()) | ||
| .doOnConnection(c -> ServerCloseHandler.register(c, serverCloseLatch, isHttp11)) | ||
| .metrics(true, () -> ServerRecorder.INSTANCE, Function.identity()) |
There was a problem hiding this comment.
Do we need this to be always a new Supplier?
|
Closing this PR, which will be superseded by another 1.0.x upcoming PR. |
|
This is superseded by #2391 |
violetagg
added
the
status/superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the HttpMetricsHandlerTests.testServerConnectionsRecorder() test fails with the following exception:
Such exception can happen if the checkServerConnectionsRecorder method throws some exceptions.
So, the PR first catches any exceptions thrown from checkServerConnectionsRecorder, and then display it from the testServerConnectionsRecorder method.
So, we can now observe this root cause exception:
So, what is failing is this check from checkServerConnectionsRecorder method:
So, when checkServerConnectionsRecorder() is called, the number of connections on the server is surprisingly 0 instead of 1 !
I think it's a concurrency issue which may happen if CI is slow. Here is the reproducer scenario I can imagine for the moment:
we are testing an HTTP2 test, and the test succeeds, so when tearDown is called, the client connection provider is disposed. But because the system is slow, the server does not immediately see the close, it will see it very shortly, in few nanoseconds
so, the next test is now executing, and then the ServerRecorder.recordServerConnectionOpened() is called: onServerConnectionsAmount is set to 1, but right after, recordServerConnectionClosed is called because the previous server test is still closing -> in this case, onServerConnectionsAmount is decremented and is wrongly set to 0
The PR is an attempt to fix this issue: it first dispose the client connection provider, then it waits for the recordServerConnectionClosed to be called, then it asserts the test expectations. This patch also simplifies a bit the test because the "done" CountDownLatch has been removed, and a new "ServerCloseHandler" is used to ensure the server has seen its client socket closed.
Now, using the patch, I restarted the CI many times and could not reproduce the problem anymore.