Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpMetricsHandlerTests testServerConnectionsMicrometer still unstable #2421

Merged
merged 3 commits into from
Aug 18, 2022
Merged

HttpMetricsHandlerTests testServerConnectionsMicrometer still unstable #2421

merged 3 commits into from
Aug 18, 2022

Commits on Aug 8, 2022

  1. HttpMetricsHandlerTests testServerConnectionsMicrometer is still unst… 

    …able
    @pderop
    pderop committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    ebd6d9d View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Ensure client sockets are closed on the server before testing server … 

    …metrics like SERVER_CONNECTIONS_TOTAL. Do not dispose the server multiple times. The connection pool provider was disposed by some tests, that's not necessary.
    @pderop
    pderop committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    3ce4ff9 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Applied feedback, the group is also closed, like in ITTracingHttpServ… 

    …erDecoratorTest
    @pderop
    pderop committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    f681c14 View commit details
    Browse the repository at this point in the history