Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Netty contribs from main branches #2457

Merged
merged 1 commit into from Aug 31, 2022

Conversation

pderop
Copy link
Member

@pderop pderop commented Aug 31, 2022

The Netty contribs (codec-extras, codec-haproxy, socks-proxy) have been merged into their main branches with the following fixed PRs:

So, we can now point to the contribs main branches instead of their PR branches

@pderop pderop self-assigned this Aug 31, 2022
@pderop pderop added this to the 2.0.0-M2 milestone Aug 31, 2022
@pderop pderop added the type/enhancement A general enhancement label Aug 31, 2022
@pderop
Copy link
Member Author

pderop commented Aug 31, 2022

@reactor/core-team ,

can you review this please (the remaining failed test from the CI is not related and is known, see )

thank you.

@pderop pderop requested a review from a team August 31, 2022 10:09
@pderop
Copy link
Member Author

pderop commented Aug 31, 2022

@simonbasle , @OlegDokuka , thanks for the review.

@pderop pderop merged commit d0edde6 into reactor:netty5 Aug 31, 2022
@pderop pderop deleted the use-netty-contribs-from-main-branches branch August 31, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants