Use HttpConnectionProvider mutate method (#2463) #2463
Conversation
|
@yangbongsoo Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@yangbongsoo Thank you for signing the Contributor License Agreement! |
| return ConnectionProvider.super.mutate(); | ||
| } | ||
|
|
||
| return this.http1ConnectionProvider.mutate(); |
There was a problem hiding this comment.
I know that I haven't considered h2ConnectionProvider yet.
I'd like to hear the opinion of the maintainer.
| .build(); | ||
|
|
||
| assertThat(beforeProvider.maxConnections()).isEqualTo(mergedProvider.maxConnections()); | ||
| assertThat(beforeProvider.name()).isEqualTo(mergedProvider.name()); |
There was a problem hiding this comment.
I wanted to compare more values, but it was inaccessible.
|
@yangbongsoo My idea was not to implement Then the code below will return Wdyt? |
|
I made new PR as you recommand. #2468 |
|
This is superseded by #2483 |
violetagg
added
status/superseded
I made mutate method(overriding) in HttpConnectionProvider.
However I can't access
Builderclass directly.So I edit mutate method in ConnectionProvider default method
relates: #2462