Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get SslHandler by name for ALPN in HttpClientChannelInitializer #2488

Closed
wants to merge 2 commits into from
Closed

Get SslHandler by name for ALPN in HttpClientChannelInitializer #2488

wants to merge 2 commits into from

Commits on Sep 15, 2022

  1. Get SslHandler by name for ALPN in HttpClientChannelInitializer 

    Switch to accessing the SslHandler by name in client ALPN. This should always return the SslHandler for remote endpoint. If we don't do this, the pipeline will always return the first SslHandler in the pipeline. When talking through a TLS enabled forward proxy there may be more than one SslHandler present in the pipeline. This change ensures that we always get the SslHandler for the remote HTTP endpoint and not an intermediary, ensuring we set the correct negotiated protocol.

Fixes reactor#2480
    @j-bahr
    j-bahr committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    c697c94 View commit details
    Browse the repository at this point in the history

  2. Update reactor-netty-http/src/main/java/reactor/netty/http/client/Htt… 

    …pClientConfig.java
    @violetagg
    violetagg committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    458a7f4 View commit details
    Browse the repository at this point in the history