Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JapiCmp: avoid misses, improve reporting and exclusions #2497

Merged
merged 3 commits into from Sep 26, 2022

Commits on Sep 21, 2022

  1. Improve JapiCmp: avoid misses, improve reporting and exclusions

    This commit improves the japicmp integration in the build:
    
    1) Add a finalizedBy task that prints a filtered report
    
    The basic text report uses * and ! as markers for binary and source
    incompatible changes respectively. Additionally, a MODIFIED class is
    marked with ***. This task attempts at pinpointing the incompatible
    changes only in the report, and printing these lines.
    
    This report is called out in the "how to fix" tip in the CI preliminary
    step.
    
    2) Ensure sourceModified changes are considered
    
    See reactor/reactor#722.
    
    If a change is binary compatible but not source compatible, using
    `onlyBinaryCompatibleModified = true` will mask the issue. This
    change uses `onlyModified = true` instead. This is slightly more
    verbose, but this is alleviated by (1).
    
    3) Exclude NEW_DEFAULT_METHOD as a whole
    
    Since japicmp-grale-plugin v0.4.1 the new `compatibilityChangeExcludes`
    parameter allows us to ignore all occurrences of a default method added
    to an interface, instead of having to exclude each such method one by
    one.
    simonbasle committed Sep 21, 2022
    Copy the full SHA
    cf3b61c View commit details
    Browse the repository at this point in the history
  2. oops, botched copy paste

    simonbasle committed Sep 21, 2022
    Copy the full SHA
    dcc9b29 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Copy the full SHA
    c8c72dd View commit details
    Browse the repository at this point in the history