Ensure IdleTimeoutHandler receives always channelRead events
#2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When the server is configured with HTTP/1.1 and H2C ensure Http2MultiplexHandler is at the end of the pipeline because this handler doesn't forward all channelRead events. - When the server is configured with HTTP/1.1 and H2 and the client sends HTTP/1.1, when channelActive event happens, HttpTrafficHandler is still not in the pipeline. In this use case add IdleTimeoutHandler when HttpTrafficHandler is added to the pipeline. Fixes #2649
pderop
approved these changes
Jan 19, 2023
…r is added at the point when HTTP/1.1 is negotiated Previously it was added with HttpTrafficHandler#handlerAdded, for this use case this is correct, but for the other use cases we don't want to add IdleTimeoutHandler at this point because we don't want this handler to participate in the TLS handshake.
On a second thought, although that |
|
@pderop Thanks for the review! |
violetagg
added a commit
that referenced
this pull request
Jan 20, 2023
violetagg
added a commit
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/1.1andH2CensureHttp2MultiplexHandleris at the end of the pipeline because this handler doesn't forward allchannelReadevents.HTTP/1.1andH2and the client sendsHTTP/1.1, whenchannelActiveevent happens,HttpTrafficHandleris still not in the pipeline. In this use case addIdleTimeoutHandlerwhenHttpTrafficHandleris added to the pipeline.Fixes #2649