Cache the request info when collecting metrics #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed test on CI is not relevant |
pderop
reviewed
Apr 29, 2024
...tor-netty-http/src/main/java/reactor/netty/http/server/AbstractHttpServerMetricsHandler.java
Outdated
Show resolved
Hide resolved
Do not search for HttpServerOperations every time when a request info is needed.
violetagg
force-pushed
the
cache-request-info
branch
from
5a416b8
to
5e3918f
Compare
pderop
reviewed
Apr 29, 2024
...tor-netty-http/src/main/java/reactor/netty/http/server/AbstractHttpServerMetricsHandler.java
Outdated
Show resolved
Hide resolved
|
@pderop Thanks for the review! |
violetagg
added a commit
that referenced
this pull request
Apr 30, 2024
violetagg
added a commit
that referenced
this pull request
Apr 30, 2024
violetagg
added a commit
that referenced
this pull request
May 7, 2024
…erations This is in addition to #3211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not search for
HttpServerOperationsevery time when a request info is needed.