Merge pull request #1647 from nylon22/master

fix(CustomInput): remove type prop from input node when type is select #1617
reactstrap · Oct 4, 2019 · ceb482b · ceb482b
2 parents 7b3f710 + 3e4c23f
commit ceb482b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/CustomInput.js b/src/CustomInput.js
@@ -54,7 +54,8 @@ function CustomInput(props) {
   const labelHtmlFor = htmlFor || attributes.id;
 
   if (type === 'select') {
-    return <select {...attributes} ref={innerRef} className={classNames(validationClassNames, customClass)}>{children}</select>;
+    const { type, ...rest } = attributes;
+    return <select {...rest} ref={innerRef} className={classNames(validationClassNames, customClass)}>{children}</select>;
   }
 
   if (type === 'file') {

diff --git a/src/__tests__/CustomInput.spec.js b/src/__tests__/CustomInput.spec.js
@@ -202,6 +202,11 @@ describe('Custom Inputs', () => {
       expect(select.find('select').prop('data-testprop')).toBe('yo');
     });
 
+    it('should remove type prop from the input node', () => {
+      const select = mount(<CustomInput type="select" />);
+      expect(select.find('select').prop('type')).toBeUndefined();
+    });
+
     it('should reference innerRef to the select node', () => {
       const ref = React.createRef();
       mount(<CustomInput type="select" innerRef={ref} />);