react-popper 1.0.x compliant

[sevdog]

Issue description

The following components (at least) should be updated to use the latest version of react-popper (branch 1.0.x, which was first released on 14h June)

• components: PopperContent, DropdownToggle

What is happening?

As of now, these components are using Target and Arrow imported from react-popper which have been removed/reworked in version 1.0.x.

What should be happening?

These components should use new react-popper APIs and dependency should change to use branch 1.0.x.

[virgofx]

Right now the 1.0.x build also breaks externally as it didn't include the proper UMD external Rollup build config from 0.10.x. So before supporting 1.0.x , react-popper will need to be fixed upstream.

[sevdog]

UMD rollup was not fixed in this PR?

[virgofx]

I know I checked the original 1.0.0 and I believe 1.0.1 and it did not work. The rollup was still broken. We merged some fixes into the v.0.10.x series that never made it to the 1.0. They don't do a lot of testing on the external.

You can test it right now by using the example external code in the Readme and attempt to pull in the specific versions of react-popper.

[sevdog]

I've created this gist based on Reactstrap's Readme (which also need to be updated, cause TooltipTrigger and TooltipContent are not in the codebase).

On my machine there were no errors with ReactPopper (tested with Chrome and Edge), but the example remains broken cause APIs have been changed.

[virgofx]

1.0.2 may have fixed it ... I'll reconfirm also

[virgofx]

FYI - 1.0.2 doesn't work externally ... need to fix react-popper Rollup build process.

[sevdog]

Maybe I have made a mistake in previous gist.

So I have setup an other example which is working for me (no console errors, and UI behave as expected).
In this example I also addes react-bootstrap-typeahead which uses react-popper directly for its menus.

If this is not working for other I will create an issue on react-popper as I can.

[alamothe]

+1

Would be great to update react-popper dependency!

[dcousens]

If you use react-popper@1.0.2 and this project together, you will run into confusing errors.

[sevdog]

If you use react-popper@1.0.2 and this project together, you will run into confusing errors.

This is obvious because there are breaking changes in react-popper since 1.0.0-beta4.

[fnpen]

@virgofx

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/react-popper/1.3.2/umd/react-popper.min.js"></script>
console.log(ReactPopper); -> output object with methods

Is working correct.

They have changed API.
You need help with change code? Because you are writing here about UMD config problems.

Thank you!

[virgofx]

Let me confirm again ... I know they re-released a few versions let me check.

[fnpen]

Let me confirm again ... I know they re-released a few versions let me check.

I've migrated to 1.3.x and fix tests also, but I had problems with old context API. I make helper to work with it.

#1376

[sevdog]

Since #1427 was merged and now this package requires "react-popper": "^1.3.6".

This issue can be closed, thanks.