Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popper) react-popper migration v1.3 #1376

Closed
wants to merge 2 commits into from
Closed

feat(Popper) react-popper migration v1.3 #1376

wants to merge 2 commits into from

Conversation

fnpen
Copy link

@fnpen fnpen commented Jan 22, 2019

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I've migrated to 1.3.x and fix tests also, but I had problems with old context API. I make helper to work with it.

Relevant issue: #1197

@fnpen
Copy link
Author

fnpen commented Jan 28, 2019

@virgofx, do you have any news?

@RVxLab
Copy link

RVxLab commented Feb 14, 2019

I would really like this to be merged. It's currently breaking with other packages that require react-popper >= 1.0.2

@dgreensp
Copy link

@fnpen I'm just a random passer-by, but, what problems did you run into, and do you need help trying to solve them? Or is this ready for review?

@fnpen
Copy link
Author

fnpen commented Apr 1, 2019

@fnpen I'm just a random passer-by, but, what problems did you run into, and do you need help trying to solve them? Or is this ready for review?

I'm waiting for somebody to review it, like others. But nobody supports this repo :-(
@virgofx is assigned as the reviewer, but he ignores my questions here.

@TheSharpieOne
Copy link
Member

This was updated in #1427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants