Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Progress): Allow passing in custom style object #1771

Merged
merged 1 commit into from Jan 28, 2020

Conversation

DSBalaban
Copy link
Contributor

@DSBalaban DSBalaban commented Jan 28, 2020

Allows for more flexibility in styling

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Ran into a scenario where I could use passing in styles in this manner.
My use case involves mapping over a collection and creating slightly rounded progress bars which overlap (to cover the space created at the corners by border-radius), and I could use the ability of passing in zIndex values programmatically.

I realize this makes Progress "special", seeing as none of the other components accept the style prop. If you want me to do this for all components, let me know.

EDIT: DropdownMenu › should not render multiple children when isOpen is false fails, but it shouldn't be because of this PR.

Allows for more flexibility in styling
@kyletsang
Copy link
Member

kyletsang commented Jan 12, 2021

Unfortunately, this broke the ability to set style into the parent progress container. Going to expose this feature under a new prop called barStyle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants