Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dropdown disabled toggle issue #1571

Merged
merged 2 commits into from Jul 12, 2019
Merged

fix: Dropdown disabled toggle issue #1571

merged 2 commits into from Jul 12, 2019

Commits on Jul 11, 2019

  1. fix: Dropdown disabled toggle issue 

    This fix addresses the issue where Dropdown will be passed a
`disabled` prop, yet it is still clickable. This is due to context
being passed the user-defined `toggle` prop directly, rather than
our defined `this.toggle` function that includes a check for
`disabled`.

Fixes reactstrap#1542
    @bpas247
    bpas247 committed Jul 11, 2019
    Copy the full SHA
    cfa3b47 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. fix: incorrect test assertion 

    In the previous implementation, Dropdown wasn't properly firing
the toggle function within Dropdown, so the assertion was written
down wrong to compensate for that.
    @bpas247
    bpas247 committed Jul 12, 2019
    Copy the full SHA
    27c8dd4 View commit details
    Browse the repository at this point in the history