Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NavbarToggler): add aria-label to NavbarToggler #1633

Merged
merged 1 commit into from Sep 28, 2019
Merged

feat(NavbarToggler): add aria-label to NavbarToggler #1633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NavbarToggler.js
View file
Open in desktop
Expand Up @@ -31,7 +31,7 @@ const NavbarToggler = (props) => {
), cssModule);

return (
<Tag {...attributes} className={classes}>
<Tag aria-label="Toggle navigation" {...attributes} className={classes}>
{children || <span className={mapToCssModules('navbar-toggler-icon', cssModule)} />}
</Tag>
);
Expand Down
7 changes: 4 additions & 3 deletions src/__tests__/NavbarToggler.spec.js
View file
Open in desktop
Expand Up @@ -6,19 +6,20 @@ describe('NavbarToggler', () => {
it('should render .navbar-toggler markup', () => {
const wrapper = shallow(<NavbarToggler />);

expect(wrapper.html()).toBe('<button type="button" class="navbar-toggler"><span class="navbar-toggler-icon"></span></button>');
expect(wrapper.prop('aria-label')).toBe('Toggle navigation');
expect(wrapper.html()).toBe('<button aria-label="Toggle navigation" type="button" class="navbar-toggler"><span class="navbar-toggler-icon"></span></button>');
});

it('should render custom tag', () => {
const wrapper = shallow(<NavbarToggler tag="div" />);

expect(wrapper.html()).toBe('<div type="button" class="navbar-toggler"><span class="navbar-toggler-icon"></span></div>');
expect(wrapper.html()).toBe('<div aria-label="Toggle navigation" type="button" class="navbar-toggler"><span class="navbar-toggler-icon"></span></div>');
});

it('should render children instead of navbar-toggler-icon ', () => {
const wrapper = shallow(<NavbarToggler>Children</NavbarToggler>);

expect(wrapper.html()).toBe('<button type="button" class="navbar-toggler">Children</button>');
expect(wrapper.html()).toBe('<button aria-label="Toggle navigation" type="button" class="navbar-toggler">Children</button>');
});

it('should pass additional classNames', () => {
Expand Down