Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UncontrolledCarousel): use item.key instead of item.src as key prop in CarouselItems #1649

Merged
merged 2 commits into from Oct 7, 2019
Merged

fix(UncontrolledCarousel): use item.key instead of item.src as key prop in CarouselItems #1649

merged 2 commits into from Oct 7, 2019

Commits on Oct 7, 2019

  1. fix(UncontrolledCarousel): use item.key instead of item.src as key pr… 

    …op in CarouselItems

See reactstrap#1536

Resolves issue where if the UncontrolledCarousel contains CarouselItems with the same src, the following react error gets emitted:

```
Warning: Encountered two children with the same key, `https://xxx.png`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
```
    Tyson Warner committed Oct 7, 2019
    Copy the full SHA
    2f5eb9d View commit details
    Browse the repository at this point in the history

  2. refactor(UncontrolledCarousel): remove warning message for undefined … 

    …item key
    Tyson Warner committed Oct 7, 2019
    Copy the full SHA
    81b6c5c View commit details
    Browse the repository at this point in the history