Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key in UncontrolledCarousel #1650

Closed
wants to merge 2 commits into from
Closed

Fix key in UncontrolledCarousel #1650

wants to merge 2 commits into from

Conversation

baktiaditya
Copy link

@baktiaditya baktiaditya commented Oct 7, 2019 •
edited

fix #1536

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@baktiaditya baktiaditya mentioned this pull request Oct 7, 2019
Closed
@GoPro16
Copy link
Member

GoPro16 commented Oct 7, 2019 •
edited by TheSharpieOne

superseded by #1649

@GoPro16 GoPro16 closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UncontrolledCarousel should not use src of an item as key
2 participants
@baktiaditya @GoPro16