Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bumps react-transition-group to 4.3.0 (#1738) #1742

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

thecodejack
Copy link

Fixes #1738

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Have also tested manually react-transition-group consumed components which are Carousel, Collapse, Fade

@TheSharpieOne
Copy link
Member

The usage of react-transition-group within reactstrap require react and react-dom of ^16.6.0, but the peerDep within our package.json is still ^16.3.0. The reason it works for things like the netlify preview (and locally) is because the version it runs is 16.8.6.
Can you bump the peerDep (at least ^16.6.0 but maybe want to jump to ^16.8.0 min version so we can use hooks) and mark the commit as a breaking change?

@thecodejack
Copy link
Author

sure. It makes sense to update the peer dependancies. I will do that.

But the part I don't understand is why should this be a breaking change? I mean any app using react <16.8.x and >16.3.0 should be able to upgrade without any changes.

@thecodejack
Copy link
Author

Ok. I see it failing if deps are mentioned this way

"react": "16.3.0",
"reactstrap": "^8.2.0"

Is it worth making a major release for this?

@TheSharpieOne
Copy link
Member

The next release is going to be a major after a fix accidentally introduced a breaking change. Change you update this PR to make the changes to the peerDeps?

@thecodejack
Copy link
Author

@TheSharpieOne Have updated peer dependencies via e64b199

@thecodejack
Copy link
Author

@TheSharpieOne Do I need to do anything for this PR or it's waiting for Major release?

@TheSharpieOne
Copy link
Member

Waiting on a major. I really want to get forwardRef stuff in with this next breaking change. I haven't had time. Hoping to get it done sometime this month.

@GoPro16
Copy link
Member

GoPro16 commented Feb 26, 2020

Waiting on a major. I really want to get forwardRef stuff in with this next breaking change. I haven't had time. Hoping to get it done sometime this month.

@TheSharpieOne I was going to plan on fixing #1356 in the next day if you can hold off before then. Then we can merge this in as well and kill 2 birds with one stone

@azizur
Copy link

azizur commented May 11, 2020

Any update on this? There has been a new https://github.com/reactjs/react-transition-group/releases release 4.4.1 reactjs/react-transition-group#429 (comment)

@noacohen
Copy link

Do you know what is the expected date to release this update?

@andefred
Copy link

Any update on this? Is there anything I can do to help?

@phwebi
Copy link
Member

phwebi commented Sep 7, 2021

Update: we have react-transition-group bumped to 4.4.2 on the bootstrap5 upgrade branch. The plan is to do a major release for the Bootstrap 5 updates after some further testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update react-transition-group package
7 participants