New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bumps react-transition-group to 4.3.0 (#1738) #1742
base: master
Are you sure you want to change the base?
Conversation
bumps react-transition-group from 2.3.1 to 4.3.0 - [Release notes] https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md
The usage of react-transition-group within reactstrap require react and react-dom of |
sure. It makes sense to update the peer dependancies. I will do that. But the part I don't understand is why should this be a breaking change? I mean any app using react <16.8.x and >16.3.0 should be able to upgrade without any changes. |
Ok. I see it failing if deps are mentioned this way
Is it worth making a major release for this? |
The next release is going to be a major after a fix accidentally introduced a breaking change. Change you update this PR to make the changes to the peerDeps? |
BREAKING CHANGE: upgrade peer deps react, react-dom 16.8.0
@TheSharpieOne Have updated peer dependencies via e64b199 |
@TheSharpieOne Do I need to do anything for this PR or it's waiting for Major release? |
Waiting on a major. I really want to get forwardRef stuff in with this next breaking change. I haven't had time. Hoping to get it done sometime this month. |
@TheSharpieOne I was going to plan on fixing #1356 in the next day if you can hold off before then. Then we can merge this in as well and kill 2 birds with one stone |
Any update on this? There has been a new https://github.com/reactjs/react-transition-group/releases release 4.4.1 reactjs/react-transition-group#429 (comment) |
Do you know what is the expected date to release this update? |
Any update on this? Is there anything I can do to help? |
Update: we have |
Fixes #1738
Have also tested manually react-transition-group consumed components which are Carousel, Collapse, Fade