Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PopoverContent): add x-out-of-boundaries attribute #1836

Merged
merged 1 commit into from May 21, 2020
Merged

feat(PopoverContent): add x-out-of-boundaries attribute #1836

merged 1 commit into from May 21, 2020

Conversation

khanilov
Copy link
Contributor

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This attribute is required to use Popper's hide modifier, in order to indicate that element left container boundaries. In such case, for example, it can be hidden.

Closes #1835

@iamandrewluca iamandrewluca merged commit 607ce10 into reactstrap:master May 21, 2020
@iamandrewluca
Copy link
Contributor

@khanilov Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add x-out-of-boundaries attribute to popover
2 participants
@khanilov @iamandrewluca