fix: use new react-transition-group api #2402
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of
react-transition-group
does not solve warnings in StrictMode.react-transition-group
has a new API that uses refs instead offindDOMNode
This does not completely get rid of StrictMode warnings, it seems that Carousel is still using legacy context API. I made a PR related to this in the past, #1831 but the tests break
Related #1289
Related #1340
Related #1992
Related #1289
Related #1833
Related #1468
Related #1738
ps1: I am the author of new
react-transition-api
API that uses refs reactjs/react-transition-group#559ps2: I had access to this repo in the past, but I reset 2FA, and I lost access to it