Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new react-transition-group api #2402

Closed
wants to merge 2 commits into from
Closed

fix: use new react-transition-group api #2402

wants to merge 2 commits into from

Conversation

iamandrewluca
Copy link
Contributor

@iamandrewluca iamandrewluca commented Nov 21, 2021

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Update of react-transition-group does not solve warnings in StrictMode.
react-transition-group has a new API that uses refs instead of findDOMNode

This does not completely get rid of StrictMode warnings, it seems that Carousel is still using legacy context API. I made a PR related to this in the past, #1831 but the tests break

Related #1289
Related #1340
Related #1992
Related #1289
Related #1833
Related #1468
Related #1738

ps1: I am the author of new react-transition-api API that uses refs reactjs/react-transition-group#559
ps2: I had access to this repo in the past, but I reset 2FA, and I lost access to it

@iamandrewluca iamandrewluca marked this pull request as ready for review November 21, 2021 13:43
@FPDK
Copy link

FPDK commented Jan 15, 2022

Any news on the merge status? Would be nice to get it merged even though Carousel might still produce warnings.

@didaquis
Copy link

Any update?

@iamandrewluca iamandrewluca deleted the fix-strict-mode-warnings branch March 20, 2022 19:14
@rhengles
Copy link

@iamandrewluca Why did you close this ?

@iamandrewluca
Copy link
Contributor Author

iamandrewluca commented Mar 22, 2023

@rhengles PR didn't get any attention for a few months and decided to close. Can be recreated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants