Node update #2695
Draft
Node update #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidacevedo
commented
Feb 4, 2023
davidacevedo
commented
- Bug fix
- New feature
- Chore
- Breaking change
- There is an open issue which this change addresses
- I have read the CONTRIBUTING document.
- My commits follow the Git Commit Guidelines
- My code follows the code style of this project.
- My change requires a change to the documentation.
- I have updated the documentation accordingly.
- My change requires a change to Typescript typings.
- I have updated the typings accordingly.
- I have added tests to cover my changes.
- All new and existing tests passed.
This will make us follow React best practices and depend on libraries that are expecting ref to exist
…efining them as such Tests were failing because the top level component was a wrapper vs the actual component that was exposed. This also makes it so defaultProps and PropTypes are attached to the actual component exported.
davidacevedo
force-pushed
the
nodeUpdate
branch
2 times, most recently
from
60358f3
to
a8ad998
Compare
davidacevedo
force-pushed
the
nodeUpdate
branch
from
a8ad998
to
a42248a
Compare
|
Released prerelease version |
| @@ -16,7 +16,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: [12.x, 14.x, 16.x] | |||
| node-version: [14.x, 16.x] | |||
There was a problem hiding this comment.
I think we can add node 18.x also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.