Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2744): Toast fade fix with display block #2770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidlyons
Copy link

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Boostrap has a .toast style that breaks Reactstrap's Toast fade transition.
This PR overrides the Toast's display: none with the d-block utility class to fix the fade transition.

Fix for #2744

@davidlyons davidlyons changed the title fix(reactstrap#2744): Toast fade fix with display block fix(#2744): Toast fade fix with display block Sep 16, 2023
@illiteratewriter
Copy link
Member

@davidlyons Great catch on finding what was causing the issue.

The PR kind of fixes the issue but this is causing Reactstrap to behave differently from how Bootstrap is behaving right now. Ideally, we would like to have the same behaviour that Bootstrap is providing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants